Fix for sysbox issue #544 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: Cherry-picked from OCI runc commit b3d14488b5eeef399295d70d7acd49b451c20179 (original author flouthoc), with minor changes for sysbox-runc. Signed-off-by: Cesar Talledo <ctalledo@nestybox.com>
NOTE: cherry picked from OCI runc commit 8f1b4d4a6f5cc1798c148bcf29cfdbdb465c44e3 (original author Kir Kolyshkin)
and adjusted for Sysbox by ctalledo.
Original commit:
This is a better place as cgroups itself is using these.
Should help with moving more stuff common in between fs and fs2 to
fscommon.
Looks big, but this is just moving the code around:
fscommon/{fscommon,open}.go -> cgroups/file.go
fscommon/fscommon_test.go -> cgroups/file_test.go
and fixes for TestMode moved to a different package.
There's no functional change.
---
Signed-off-by: Cesar Talledo <ctalledo@nestybox.com>
Commit a6023ce introduced a bug that was causing sysbox-runc to not setup the continer's cgroups properly, specifically the softlinks under /sys/fs/cgroup such as: drwxr-xr-x 3 root root 0 May 13 20:46 blkio lrwxrwxrwx 1 root root 11 May 13 20:46 cpu -> cpu,cpuacct drwxr-xr-x 3 root root 0 May 13 20:46 cpu,cpuacct lrwxrwxrwx 1 root root 11 May 13 20:46 cpuacct -> cpu,cpuacct (i.e., the softlinks were missing inside the sysbox container due to a bug in that commit). This change fixes this. Signed-off-by: Cesar Talledo <ctalledo@nestybox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.